Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with ECCO metadata_url and urls both adding a trailing / #318

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Fix bug with ECCO metadata_url and urls both adding a trailing / #318

wants to merge 8 commits into from
+36 −20

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Dec 24, 2024

Close #316

@navidcy navidcy requested review from glwagner and simone-silvestri and removed request for glwagner December 24, 2024 07:33
@navidcy navidcy added the build docs Add this label to built the docs in a PR label Dec 24, 2024
@navidcy navidcy added the bug Something isn't working label Dec 24, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (3d76db9) to head (530f3f4).

Files with missing lines Patch % Lines
src/DataWrangling/ECCO/ECCO_metadata.jl 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##            main    #318   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         34      34           
  Lines       1983    1983           
=====================================
  Misses      1983    1983

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navidcy navidcy mentioned this pull request Dec 24, 2024
Merged
@navidcy
Copy link
Collaborator Author

navidcy commented Dec 25, 2024

So we can literate this example, but I don't know what to do with the sliders. I don't think we can have sliders in the docs...
At the moment, it looks like:
https://clima.github.io/ClimaOceanDocumentation/previews/PR318/literated/ecco_inspect_temperature_salinity/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simone-silvestri simone-silvestri Awaiting requested review from simone-silvestri

@glwagner glwagner Awaiting requested review from glwagner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working build docs Add this label to built the docs in a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ECCO's metadata_url and urls both add a / between the url's path and filename
1 participant
@navidcy